We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5005

Summary: [patch] warnings in kmsdrm
Product: SDL Reporter: Malte Kießling <mkalte>
Component: videoAssignee: Sam Lantinga <slouken>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2    
Version: HG 2.0   
Hardware: x86_64   
OS: Linux   
Attachments: patch

Description Malte Kießling 2020-02-25 20:46:28 UTC 
Created attachment 4228 [details]
patch

At the moment i get following warnings from kmsdrm: 

 * in SDL_kmsdrmvideo.c KMSDRM_DestroySurfaces is return type int, but thats never returned or checked against 
 * in SDL_kmsdrmvideo.c KMSDRM_DestroySurfaces the variable viddata is not used
 * in SDL_kmsdrmopengles.c KMSDRM_GLES_LoadLibrary a cast to NativeDisplayType is missing

I attached a patch for them :) 
I think changing KMSDRM_DestroySurfaces to void is ok? Its not used anywhere else and its a quite recent addition if i read the commit logs right. 

~mkalte
Comment 1 Sam Lantinga 2020-02-27 16:20:51 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/936b1869a34a