| Summary: | mp3_skiptags update and mpg123 duration fix | ||
|---|---|---|---|
| Product: | SDL_mixer | Reporter: | Ozkan Sezer <sezeroz> |
| Component: | misc | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | CC: | admin |
| Version: | unspecified | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Attachments: |
mp3utils1.patch - let mpg123 keep id3v2
mp3utils2.patch - mp3_skiptags() update |
||
|
Description
Ozkan Sezer
2019-12-19 23:49:47 UTC
Created attachment 4120 [details]
mp3utils1.patch - let mpg123 keep id3v2
Created attachment 4121 [details]
mp3utils2.patch - mp3_skiptags() update
Note that there are several MP3 files with an invalid length in ID3v2 tag which makes mpg123 return an incorrect duration. (In reply to Vitaly Novichkov from comment #3) > Note that there are several MP3 files with an invalid length > in ID3v2 tag which makes mpg123 return an incorrect duration. That is a problem of libmpg123 we cannot, and should not try to, solve by ourselves. Patches applied: https://hg.libsdl.org/SDL_mixer/rev/ba8b8227a7bd https://hg.libsdl.org/SDL_mixer/rev/2e69576079bd https://hg.libsdl.org/SDL_mixer/rev/91dc8a87aaee https://hg.libsdl.org/SDL_mixer/rev/4e1c2282e6f1 If any issues are revealed, or if improvements can be made to them, please drop a note here. |