We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4745

Summary: 2.0.10 fails to build against macOS 10.11 SDK
Product: SDL Reporter: Joshua Root <josh+sdl>
Component: videoAssignee: Sam Lantinga <slouken>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2 CC: icculus, sezeroz
Version: 2.0.10   
Hardware: x86   
OS: Mac OS X 10.11   
Attachments: patch that fixes the build

Description Joshua Root 2019-07-30 01:19:41 UTC 
Created attachment 3908 [details]
patch that fixes the build

NSEventSubtypeMouseEvent was added in 10.12 [1], so it needs to be defined on 10.11 as well. NSEventSubtypeTouch on the other hand has been around since 10.6, so defining it seems to be redundant.

[1] https://developer.apple.com/documentation/appkit/nseventsubtype/nseventsubtypemouseevent?language=objc
Comment 1 Ozkan Sezer 2019-07-30 09:10:18 UTC 
(In reply to Joshua Root from comment #0)
>  NSEventSubtypeTouch on the other hand has been around
> since 10.6, so defining it seems to be redundant.

NSEventSubtypeTouch seems to appear in SDK 10.12 headers.
(but I don't see its use in SDL2...)
Comment 2 Joshua Root 2019-07-30 12:09:50 UTC 
Right, it's already defined in the headers (for all supported Mac OS versions), so no need for SDL to define it itself.
Comment 3 Ryan C. Gordon 2019-07-30 13:58:55 UTC 
(In reply to Joshua Root from comment #0)
> NSEventSubtypeTouch on the other hand has been around
> since 10.6, so defining it seems to be redundant.

I'm a little nervous about removing this part, because this was added to fix building with the 10.10 SDK six weeks ago:

https://hg.libsdl.org/SDL/rev/75dad4c8914e

...which suggests there was something about this that wasn't actually around in 10.6...

Sam, do you remember what the deal was with this? That commit also changes the iOS project files, so I don't know what's going on in there.

--ryan.
Comment 4 Sam Lantinga 2019-07-30 17:07:22 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/449d5819a84a