| Summary: | [PATCH] cmake: Fix locating libusb header at configure-time | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Andrew Eikum <aeikum> |
| Component: | joystick | Assignee: | Sam Lantinga <slouken> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | CC: | flibitijibibo, sezeroz |
| Version: | HG 2.0 | Keywords: | target-2.0.12 |
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Attachments: |
[PATCH] cmake: Fix locating libusb header at configure-time
[PATCH] cmake: Fix locating libusb header at configure-time |
||
(Sorry if you get several emails like this, we're marking a bunch of bugs.) We're hoping to ship SDL 2.0.11 on a much shorter timeframe than we have historically done releases, so I'm starting to tag bugs we hope to have closed in this release cycle. Note that this tag means we just intend to scrutinize this bug for the 2.0.11 release: we may fix it, reject it, or even push it back to a later release for now, but this helps give us both a goal and a wishlist for the next release. If this bug has been quiet for a few months and you have new information (such as, "this is definitely still broken" or "this got fixed at some point"), please feel free to retest and/or add more notes to the bug. --ryan. This patch worked for me after changing the "or"s to "OR". Created attachment 3914 [details]
[PATCH] cmake: Fix locating libusb header at configure-time
New version that fixes the 'or' casing.
Patch added, thanks! https://hg.libsdl.org/SDL/rev/2fbd3d8432ab We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc). As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change! Thanks, --ryan. We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc). As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change! Thanks, --ryan. |
Created attachment 3895 [details] [PATCH] cmake: Fix locating libusb header at configure-time On my system, libusb's header detection failed, because it needs a -I flag. We should pass this in from pkg-config. However, the earlier check for the libusb header in the BSD section would cache the failure, so this patch also makes that check BSD-only.