| Summary: | SDL2 has missed up "SetupAPI" to link in CMakeFiles.txt and therefore can't link | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Vitaly Novichkov <admin> |
| Component: | build | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | critical | ||
| Priority: | P2 | CC: | sezeroz |
| Version: | HG 2.1 | Keywords: | target-2.0.10 |
| Hardware: | All | ||
| OS: | Windows (All) | ||
|
Description
Vitaly Novichkov
2019-07-11 22:13:10 UTC
Does it work if you replace 'advapi32' with 'setupapi' in SDL's CMakeLists.txt at around line 1338? Idk, on my end, I have added setupapi, but I kept advapi32 untouched. It has different features are not related to setupapi and I think, removal of advapi32 will cause another error. Ah yes, RegOpen??()/RegClose??() stuff need advapi32, at the least (and mingw's gcc adds it automatically behind our back). ``` gcc adds it automatically ``` I don't think it needs to trust this. The build is targeted to multiple compilers, and this behavior may be different in dependence on a compiler and it's version. Ryan, can you look at this for SDL 2.0.10 release? Fixed in https://hg.libsdl.org/SDL/rev/165d577cdc63, thanks! --ryan. Thank you, guys, for a fix! |