We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4706

Summary: OS X (darwin) builds use incorrect(?) hard-coded paths
Product: SDL Reporter: sh1 <simonhosie77+libsdl>
Component: loadsoAssignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2 CC: icculus
Version: 2.0.9Keywords: target-2.0.12
Hardware: x86   
OS: macOS 10.13   

Description sh1 2019-07-03 04:44:13 UTC
Hard-coded paths appear in configure (line ~20350) and in src/video/x11/SDL_x11opengl.c (line ~39), both referring to /usr/X11R6/lib, but for whatever reason that path is not present on my system and the correct path seems to be /opt/X11/lib.

I don't know why the paths are the way they are, but either homebrew or XQuartz or Migration Assistant (horror!) put them where they are and I don't like to question it too much.

These paths should at least respect the --x-libraries= option given to configure, right?

When they're incorrect the library builds just fine, but the fixed paths end up in the compiled library and it won't respect search paths so the X11 driver fails to load.
Comment 1 Ryan C. Gordon 2019-07-30 17:49:36 UTC
(Sorry if you get several emails like this, we're marking a bunch of bugs.)

We're hoping to ship SDL 2.0.11 on a much shorter timeframe than we have historically done releases, so I'm starting to tag bugs we hope to have closed in this release cycle.

Note that this tag means we just intend to scrutinize this bug for the 2.0.11 release: we may fix it, reject it, or even push it back to a later release for now, but this helps give us both a goal and a wishlist for the next release.

If this bug has been quiet for a few months and you have new information (such as, "this is definitely still broken" or "this got fixed at some point"), please feel free to retest and/or add more notes to the bug.

--ryan.
Comment 2 Ryan C. Gordon 2019-09-20 20:47:36 UTC
We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.
Comment 3 Ryan C. Gordon 2019-09-20 20:48:42 UTC
We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.
Comment 4 Ryan C. Gordon 2019-10-16 02:50:03 UTC
As of https://hg.libsdl.org/SDL/rev/502bb7d04f0a, we check for X11 at /opt/X11 on the Mac. XQuartz is always installed there (and if there's ever an install at /usr/X11R6, it's a symlink to /opt/X11 anyhow, so there's no reason to check for a fallback).

--ryan.