We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 467

Summary: Remove trailing "," from enums in public headers
Product: SDL Reporter: Max Horn <max>
Component: *don't know*Assignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: minor    
Priority: P2    
Version: HG 2.0   
Hardware: All   
OS: Other   
Attachments: Fix for SDL_pixels.h and SDL_video.h

Description Max Horn 2007-07-22 02:58:11 UTC 
Right now, several enums in the SDL 1.3 public headers have trailing commas. While I see the "beauty" of this (things are more symmetric, it's either to rearrange the enum constants etc.), this is bad because it will cause code which uses the GCC "-pedantic" flag to error out. Since this affects public headers, I consider this a bad thing. When comparing an esthetic gain (and those commas provide no other advantage) to breaking compilation of perfectly correct client code, I think the esthetics should be dropped...

Hence, please consider removing these trailing commas again.
Comment 1 Max Horn 2007-07-22 02:59:57 UTC 
Created attachment 230 [details]
Fix for SDL_pixels.h and SDL_video.h

This patch fixes the enums in SDL_pixels.h and SDL_video.h -- I think that's all which are affected.
Comment 2 Sam Lantinga 2007-07-22 06:23:34 UTC 
Fixed in subversion revision 3370.  Thanks!