We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4649

Summary: two potential bugs in effect_position.c file
Product: SDL_mixer Reporter: AltairPL <altairpl>
Component: miscAssignee: Ryan C. Gordon <icculus>
Status: NEW --- QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2    
Version: 2.0.4   
Hardware: x86   
OS: Windows 7   

Description AltairPL 2019-05-31 15:31:31 UTC 
1. all loops in _Eff_position_u8_c4() look like this:
    for (i = 0; i < len; i += sizeof (Uint8) * 6)
Shouldn't multiplier be 4 here (as in other _c4 functions)?

2. IMHO, angle adjustment in Mix_SetPosition() is incorrect, since passing -90 angle will simply change it to 90 instead of 270. I think it should be something like:
    angle %= 360;
    if (angle < 0) angle += 360;