| Summary: | Rework SDL_netbsdaudio to improve performance | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Nia Alarie <nia> |
| Component: | audio | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | Keywords: | target-2.0.10 |
| Version: | HG 2.0 | ||
| Hardware: | All | ||
| OS: | NetBSD | ||
| See Also: | https://bugzilla.libsdl.org/show_bug.cgi?id=3177 | ||
| Attachments: | Rework netbsdaudio | ||
Patch added, thanks! https://hg.libsdl.org/SDL/rev/f26b341b14b4 |
Created attachment 3796 [details] Rework netbsdaudio The NetBSD audio driver has a few problems. Lots of obsolete code, and extremely bad performance and stuttering. I have a patch in NetBSD's package system to improve it. This is my attempt to upstream it. The changes include: * Removing references to defines which are never used. * Using the correct structures for playback and recording, previously they were the wrong way around. * Using the correct types ('struct audio_prinfo' in contrast to 'audio_prinfo') * Removing the use of non-blocking I/O, as suggested in #3177. * Removing workarounds for driver bugs on systems that don't exist or use this driver any more. * Removing all usage of SDL_Delay(1) * Removing pointless use of AUDIO_INITINFO and tests that expect AUDIO_SETINFO to fail when it can't. These changes bring its performance in line with the DSP audio driver.