We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4594

Summary: Fix install location of CMake targets on Apple platforms
Product: SDL Reporter: tschwinger
Component: buildAssignee: Sam Lantinga <slouken>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2 Keywords: target-2.0.10
Version: HG 2.1   
Hardware: x86   
OS: Mac OS X (All)   
Attachments: Fix install location of CMake targets on Apple platforms

Description tschwinger 2019-04-12 12:22:17 UTC
Created attachment 3745 [details]
Fix install location of CMake targets on Apple platforms

Followup to #3651

As already noted by Ryan, no framework is being built, so we better install to lib/cmake.

That code was originally part of a patch submitted by David Demelier, whose credit BTW got lost (I combined his patch for #3572 with fixes for #2576 and #3613 resulting in #3651 because things started to depend on another).

I tested that the configuration files are found correctly in the new location on MacOS X based on a hint to the root (see https://cmake.org/cmake/help/latest/command/find_package.html#search-procedure).
Comment 1 tschwinger 2019-04-12 12:30:30 UTC
This patch (#4594) and #4593 can be checked out from https://github.com/tschw/SDL
Comment 2 Ryan C. Gordon 2019-05-18 18:48:53 UTC
Tagging a bunch of bugs with "target-2.0.10" so we have a clear list of things to address before a 2.0.10 release.

Please note that "addressing" one of these bugs might mean deciding to defer on it until after 2.0.10, or resolving it as WONTFIX, etc. This is just here to tell us we should look at it carefully, and soon.

If you have new information or feedback on this issue, this is a good time to add it to the conversation, as we're likely to be paying attention to this specific report in the next few days/weeks.

Thanks!

--ryan.
Comment 3 Sam Lantinga 2019-06-08 21:34:54 UTC
Patch added, thanks!
https://hg.libsdl.org/SDL/rev/74a69d4d9e9a