We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4544

Summary: SDL2.m4 SDL2.framework patch made it impossible to fail detection
Product: SDL Reporter: Stian Skjelstad <stian.skjelstad>
Component: buildAssignee: Sam Lantinga <slouken>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2    
Version: HG 2.1   
Hardware: All   
OS: All   
Attachments: check if $sdl_framework is set, before checking if directory exists

Description Stian Skjelstad 2019-03-11 22:04:50 UTC 
Created attachment 3693 [details]
check if $sdl_framework is set, before checking if directory exists

Patch that was merged here https://hg.libsdl.org/SDL/rev/9befd0acb9ef made it impossible for the SDL2 detection to fail, since one of the if statements fails to check if a variable is set or not.

if test -d $sdl_framework; then

can evaluate to true in some shells. I guess it falls into undefined behaviour when looking at the POSIX standard.
Comment 1 Sam Lantinga 2019-03-17 01:45:32 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/fa75f0fb9e96