We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4409

Summary: Pre-processor __ARM_NEON detection on arm64
Product: SDL Reporter: Sylvain <sylvain.becker>
Component: *don't know*Assignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2    
Version: don't know   
Hardware: ARM   
OS: Android (All)   
Attachments: patch

Description Sylvain 2018-12-03 08:51:32 UTC
(at least) on Android ndk-r18:

if you compile with arm64-v8a, __ARM_NEON__ isn't defined (so SDL2 doesn't include "<arm_neon.h>"), but __ARM_NEON is.

on arm-v7a, if you enable neon with Android.mk, both get defined.


https://patchwork.ozlabs.org/patch/434847/
Seems that __ARM_NEON__ is legacy and we should use __ARM_NEON
Comment 1 Sylvain 2018-12-03 08:54:08 UTC
Created attachment 3518 [details]
patch

patch
Comment 2 Sylvain 2018-12-04 11:40:29 UTC
Fixed in http://hg.libsdl.org/SDL/rev/17cb4ff70507
Comment 3 Sylvain 2018-12-04 15:55:19 UTC
Marked as fixed.