Created attachment 3424 [details]
patch

So we update the width when it's cached.
Of course, we don't update the pitch.

Also removing parenthesis of a few returns.

Created attachment 3425 [details]
patch

update of the patch: I forgot to update width variable of BlendedWrap function.

Created attachment 3427 [details]
an addition to the previous

It's an addition to the previous patch.

Currently the bitmap buffer is cropped in width, but we can also crop in height/rows.
The patch add that: the bitmap will be never more than its bounding box.

Size() function only knows the bounding box to allocate the surface, so it makes sense to use it as a boundary.

And I have removed the bound checking of Render functions. At first, It almost worked and I spot another issue so I re-worked the Size function which is know much more similar in width and height.
The bitmap is blitted at (yoffset, yoffset+maxy-miny) and we clear see it in the size function.


I fixed the BlendWrap() function that was allocating an extra un-needed memory and also fix when using TTF_USE_LINESKIP (added in bug 3679). Which could be enabled by default maybe ?

I didn't remove the bound checking from underline/strikethrough as it's still possible to make it crash, with very big outline/size for instance. (I will do it probably).

I have tested it with many fonts, including FletcherGothicFLF.ttf, which seems just a normal one.

I tried the second patch with a non-scalable font and it didn't work :(
Indeed, min/max Y metrics are filled with 0. Glyph are now clamped and so not rendered.

With an old version of SDL_ttf, it wouldn't be rendered correctly (mis aligned). So I am wondering how non-scalable should be supported / used ?

Created attachment 3431 [details]
an addition to the previous patch

Here's a new 2nd patch.

It seems to be solved by using font->height, and max(font->height, maxy - miny) as a limit. Which doesn't exceed the surface allocated memory, since we already make sure we are greater that font->height in TTF_Size() function. 

before:
  dst->rows  = SDL_min((int)dst->rows, cached->maxy - cached->miny);

after:
  int rows_max  = SDL_max(font->height,    cached->maxy - cached->miny);
  dst->rows  = SDL_min((int)dst->rows,  rows_max);



I think I also find a reason for reverting this previous commit of bug 4344
https://hg.libsdl.org/SDL_ttf/rev/7489a6f9929b
If I had a non scalable font size with almost null minx/miny, I would use the "advance" value in the same way.

before:
  dst->width = SDL_min((int)dst->width, cached->maxx - cached->minx);

after:
  int width_max = SDL_max(cached->advance, cached->maxx - cached->minx);
  dst->width = SDL_min((int)dst->width, width_max);

This 7489a6f9929b commit was to make sure there is enough memory allocated when we use "advance" as a limit.

These patches are in:
https://hg.libsdl.org/SDL_ttf/rev/38b21453a2b4

You realize that at this point the code has entirely changed and you need to do lots and lots of validation to make sure you haven't introduced any regressions, right?

I already tried with non-scalable font, but I really hit the empty metric issue with this previous patch. I'll do more test soon.

Created attachment 3434 [details]
patch for non scalable fonts

Here's a patch (diff'ed with bug 4351)

I have played more with non scalable fonts and I got them working in a better way 
by selecting the size index with FT_Select_Size. Font metrics appears into face->size->metrics.
Also glyph metrics appears correct now.

In the patch:
- Fix crash when using an invalid (negative) size index. No need to save this index.
- use FT_Select_Size to select the size, and get the size from "face->size->metrics"
- it appears glyph metrics are corrects and same as for scalable fonts. merge both cases.
  => as a consequence, we only crop the pixmap up to the [minx; maxx]x[miny, maxy]

- ttf_handling of bold style now works (before y_ppem was 0).
- lineskip is fixed. (before it was FT_CEIL'ed when it wasn't a 26.6 frac pixel).
- mis aligned (bad yoffset) is now fixed
- underline and strikethrough: face->underline_offset/height were not relevant values (cf freetype doc), 
  so use arbitrary computed values.

cannot do outline and  italic with non-scalable font:
- prevent outline
- prevent ttf_handling of italic style


I've kept in TTF_Size_Internal():
  maxx = SDL_max(maxx, x + glyph->advance);
so it allows to render a string with only one space " ". (bug 4344).

re-opening

Patch added, thanks!
https://hg.libsdl.org/SDL_ttf/rev/66fe96efd5f6