| Summary: | EGL backend changes the current context behind app's back | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Tomeu Vizoso <tomeu.vizoso> |
| Component: | video | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | CC: | icculus |
| Version: | HG 2.1 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Attachments: | fix | ||
The context needs to no longer be current:
If the EGL rendering context context is not current to any thread, eglDestroyContext destroys it immediately. Otherwise, context is destroyed when it becomes not current to any thread.
The GLX code does the same thing:
_this->gl_data->glXMakeCurrent(display, None, NULL);
_this->gl_data->glXDestroyContext(display, context);
If there's a way to tell whether the context is current, that would be the right thing to do.
(In reply to Sam Lantinga from comment #1) > The context needs to no longer be current: > If the EGL rendering context context is not current to any thread, > eglDestroyContext destroys it immediately. Otherwise, context is destroyed > when it becomes not current to any thread. > > The GLX code does the same thing: > _this->gl_data->glXMakeCurrent(display, None, NULL); > _this->gl_data->glXDestroyContext(display, context); I see that in X11_GL_InitExtensions, but not in X11_GL_DeleteContext. > If there's a way to tell whether the context is current, that would be the > right thing to do. SDL_GL_DeleteContext already takes care of that: if (SDL_GL_GetCurrentContext() == context) { SDL_GL_MakeCurrent(NULL, NULL); } _this->GL_DeleteContext(_this, context); Tomeu is right, this patch is now https://hg.libsdl.org/SDL/rev/8aa5a79c8805 Thanks! --ryan. |
Created attachment 3261 [details] fix SDL_EGL_DeleteContext calls SDL_EGL_MakeCurrent(_this, NULL, NULL); right before calling eglDestroyContext. If the context to be destroyed isn't the current one, any context tracking that the app is doing will be broken. If the context to be destroyed is the current one, SDL_GL_DeleteContext will have unset it already. This patch brings the behavior of the EGL backend in line with the one in the GLX one.