We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 414

Summary: dont include asm/page.h with HAVE_GETPAGESIZE in fbcon
Product: SDL Reporter: Mike Frysinger <vapier>
Component: videoAssignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2    
Version: HG 1.2   
Hardware: x86   
OS: Linux   

Description Mike Frysinger 2007-03-13 17:08:07 UTC
the fbcon shouldnt try including asm/page.h if getpagesize() is available ... some linux architectures are evil and actually have #error preprocessor macros in asm/page.h so merely including it will cause a build failure

--- src/video/fbcon/SDL_fbvideo.c       (revision 2990)
+++ src/video/fbcon/SDL_fbvideo.c       (working copy)
@@ -29,7 +29,9 @@
 #include <unistd.h>
 #include <sys/ioctl.h>
 #include <sys/mman.h>
+#ifndef HAVE_GETPAGESIZE
 #include <asm/page.h>           /* For definition of PAGE_SIZE */
+#endif
 #include <linux/vt.h>
 
 #include "SDL_video.h"
Comment 1 Ryan C. Gordon 2007-03-13 18:11:13 UTC
Fixed in svn revision #2991 for the 1.2 branch and #2992 for the 1.3 branch.

Thanks!

--ryan.