We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4123

Summary: DirectFB renderer cannot be enabled
Product: SDL Reporter: Michael Hamann <michael>
Component: buildAssignee: Sam Lantinga <slouken>
Status: NEW --- QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2 CC: guido.romijn
Version: 2.0.8   
Hardware: All   
OS: Linux   

Description Michael Hamann 2018-04-02 06:56:15 UTC
Due to change https://hg.libsdl.org/SDL/rev/d1ce8396c356#l1.22, the DirectFB renderer cannot be enabled anymore. As the change is otherwise totally unrelated, I assume this was not intentional. Fixing this should be trivial by reverting the affected line. This is a regression of 2.0.8 compared to 2.0.7. This breaks osk-sdl (https://github.com/postmarketOS/osk-sdl) and thus booting of postmarketOS (https://postmarketos.org) with full disk encryption.
Comment 1 Guido 2018-06-12 14:32:11 UTC
Could it be that the removal of AC_DEFINE(SDL_VIDEO_RENDER_DIRECTFB, 1, [ ]) in configure.in is to blame for this?
Comment 2 Michael Hamann 2018-06-12 15:15:01 UTC
Yes, I am sorry if this was not clear, this is exactly the line I have linked to. By "reverting the affected line" I mean re-adding that statement. I can confirm that re-adding that statement fixes this problem. I have also submitted a corresponding patch to Alpine Linux (https://github.com/alpinelinux/aports/pull/3889) with this fix that has been merged and successfully tested by other people from postmarketOS. As I have no Mac, I cannot test if this has any effect on the use of the Metal renderer (which has been introduced in the change where this line has been deleted).