| Summary: | Missing break statements in SDL_CDResume and SDL_CDStop | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Ozkan Sezer <sezeroz> |
| Component: | cdrom | Assignee: | Sam Lantinga <slouken> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | HG 1.2 | ||
| Hardware: | All | ||
| OS: | All | ||
Fixed, thanks! https://hg.libsdl.org/SDL/rev/2b3d476e2ed9 |
Two break statements are missing in SDL_cdrom.c:SDL_CDResume() and SDL_CDStop(), which negate the returned code from driver and always return 0. The following patch adds those breaks. diff --git a/src/cdrom/SDL_cdrom.c b/src/cdrom/SDL_cdrom.c --- a/src/cdrom/SDL_cdrom.c +++ b/src/cdrom/SDL_cdrom.c @@ -285,6 +285,7 @@ int SDL_CDResume(SDL_CD *cdrom) switch (status) { case CD_PAUSED: retval = SDL_CDcaps.Resume(cdrom); + break; default: retval = 0; break; @@ -307,6 +308,7 @@ int SDL_CDStop(SDL_CD *cdrom) case CD_PLAYING: case CD_PAUSED: retval = SDL_CDcaps.Stop(cdrom); + break; default: retval = 0; break;