| Summary: | errors and warnings after changeset 11917 | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Ozkan Sezer <sezeroz> |
| Component: | *don't know* | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | Keywords: | target-2.0.10 |
| Version: | HG 2.0 | ||
| Hardware: | All | ||
| OS: | Windows (All) | ||
|
Description
Ozkan Sezer
2018-03-02 20:02:37 UTC
Ryan, can you review the messagebox code? That logic for the cancel button looks wrong to me. I've committed fixes for the warnings: https://hg.libsdl.org/SDL/rev/c8b4a5166613 Thanks! (In reply to Sam Lantinga from comment #1) > I've committed fixes for the warnings: > https://hg.libsdl.org/SDL/rev/c8b4a5166613 The SDL_NORETURN tells the static analyzer that SDL_assert() enforces the conditions it checks, so it can't be removed. I'll put in a hack for mingw. --ryan. Tagging a bunch of bugs with "target-2.0.10" so we have a clear list of things to address before a 2.0.10 release. Please note that "addressing" one of these bugs might mean deciding to defer on it until after 2.0.10, or resolving it as WONTFIX, etc. This is just here to tell us we should look at it carefully, and soon. If you have new information or feedback on this issue, this is a good time to add it to the conversation, as we're likely to be paying attention to this specific report in the next few days/weeks. Thanks! --ryan. The noreturn thing is handled in https://hg.libsdl.org/SDL/rev/8a0e446a4cf9 ...this _should_ still placate MingW, please reopen if not! --ryan. |