| Summary: | SDL_windowskeyboard.c uses GetVersionExA which is deprecated past win8.1 | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Andrew <junk> |
| Component: | *don't know* | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | minor | ||
| Priority: | P2 | CC: | ssrobins |
| Version: | HG 2.0 | ||
| Hardware: | x86 | ||
| OS: | Windows 10 | ||
| Attachments: | Remove references to GetVersionExA as it's deprecated in win8.x and only used to test if SDL is running on win9x | ||
Fixed, thanks! https://hg.libsdl.org/SDL/rev/454f6dc9cb85 |
Created attachment 3123 [details] Remove references to GetVersionExA as it's deprecated in win8.x and only used to test if SDL is running on win9x GetVersionExA is deprecated in windows 8.1 and above's SDK, causing a warning when building against the win10 SDK. Attached patch cleans up the usage for a warning-free build. GetVersionExA was being used to test to see if SDL was running on win9x or winnt. A quick chat with Ryan on twitter suggested that SDL doesn't officially support win9x anymore, so the call to this can be outright removed. As an aside, replacing the call to GetVersionExA with VerifyVersionInfoA (the recommended path) would have been pointless, as VerifyVersionInfoA only supports VER_PLATFORM_WIN32_NT and doesn't officially support any other value for dwPlatformId currently. (And it's probable that win9x SDKs didn't have VerifyVersionInfo* in them anyway.) Patch attached with the quick cleanup.