We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 399

Summary: directfb patch to support SDL_GetVideoInfo
Product: SDL Reporter: couriersud
Component: videoAssignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P1 CC: couriersud
Version: 1.2.11   
Hardware: x86   
OS: Linux   
Attachments: Patch

Description couriersud 2007-02-24 13:44:27 UTC
The directfb driver will not initialize the current_w and current_h members. Consequently, SDL_GetVideoInfo will return a 0x0 screen size.

The attached patch will solve the issue.

--- SDL-1.2.11/src/video/directfb/SDL_DirectFB_video.c	2006-05-08 06:10:47.000000000 +0200
+++ libsdl1.2-1.2.11/src/video/directfb/SDL_DirectFB_video.c	2007-02-23 23:57:04.551079000 +0100
@@ -460,6 +417,8 @@
   this->info.blit_hw_A    = 1;
   this->info.blit_fill    = 1;
   this->info.video_mem    = caps.video_memory / 1024;
+  this->info.current_w    = dlc.width;  
+  this->info.current_h    = dlc.height;
 
   HIDDEN->initialized = 1;
   HIDDEN->dfb         = dfb;
Comment 1 couriersud 2007-02-24 13:46:27 UTC
Created attachment 193 [details]
Patch 

Added patch as file attachment
Comment 2 Ryan C. Gordon 2007-06-02 13:59:00 UTC
Bumping a bunch of bugs to Priority 1 for consideration for the 1.2.12 release.

--ryan.

Comment 3 Ryan C. Gordon 2007-06-04 04:18:11 UTC
Fixed in svn revision #3045 for the 1.2 branch, and #3046 for the 1.3 branch.

Thanks!

--ryan.