We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3971

Summary: [PATCH] Fix missing standard integer type definitions in yuv_rgb.c/h
Product: SDL Reporter: Zack Middleton (zturtleman) <zack>
Component: *don't know*Assignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2    
Version: HG 2.0   
Hardware: x86_64   
OS: Linux   
Attachments: Include SDL_stdinc.h in yuv_rgb.h

Description Zack Middleton (zturtleman) 2017-11-18 10:08:07 UTC
Created attachment 3091 [details]
Include SDL_stdinc.h in yuv_rgb.h

Compiling SDL HG on GNU/Linux using autotools fails in src/video/yuv2rgb/yuv_rgb.c due to missing type definitions for uint32_t and other related types.

The issue was introduced by https://hg.libsdl.org/SDL/rev/ddc0bae7ca1a which commented out including stdint.h in yuv_rgb.h. This only works when standard integer types are defined in SDL_config.h which is included in yuv_rgb.c by SDL_internal.h.

Attached is a patch that replaces including stdint.h with SDL_stdinc.h. SDL_stdinc.h either includes inttypes.h/stdint.h or assumes SDL_config.h defines the standard integer types so it should work on all platforms.
Comment 1 Sam Lantinga 2017-11-22 05:43:35 UTC
This is fixed, thanks!