| Summary: | [PATCH] Fix vsync-ed pageflips on the KMSDRM video driver | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Manuel Alfayate Corchete <redwindwanderer> |
| Component: | video | Assignee: | Sam Lantinga <slouken> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | 2.0.6 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Attachments: | Small patch that corrects vsynced pageflips on the KMSDRM driver | ||
Patch is added, thanks! https://hg.libsdl.org/SDL/rev/273acc67dbfa |
Created attachment 3022 [details] Small patch that corrects vsynced pageflips on the KMSDRM driver Hi, I noticed that, at least on Intel GPU hardware, passing SDL_RENDERER_PRESENTVSYNC would result on a static console instead of the program graphics. That was due to the fact that calling drmModePageFlip() only works if we have previously set up CRTC to one of the GBM buffers with a drmModeSetCrtc() call, so now it's done and things work as expected. The KMSDRM_GLES_SetupCrtc() call is done only one time, only when needed (when egl_swapinterval is not 0: when it's 0, there's no need for it because we flip by calling drmModePageFlip() anyway). The place where KMSDRM_GLES_SetupCrtc() call is done may look strange, but it's right: it needs EGL completely ready because it needs to call eglSwapBuffers() internally to work (see more comments about it in the code). Please, merge this as soon as possible because I need to send another patch related to KMSDRM video and I am running out of time to work on those things until next summer or so. Thanks Manuel Alfayate