We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3724

Summary: Allow Angle Static Link
Product: SDL Reporter: Carlos <madrazoman>
Component: buildAssignee: Sam Lantinga <slouken>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: enhancement    
Priority: P2 CC: madrazoman
Version: don't know   
Hardware: All   
OS: Windows (All)   
Attachments: Unix style patches to implement static angle flags
git patch for static angle flag, if its more useful

Description Carlos 2017-08-04 04:53:17 UTC
Hi!

We would like to add a switch (define) that allows us to compile Angle statically with SDL. That is, getting rid of the OpenGL DLL. Usually you need OpenGL to be loaded dynamically as DLL because implementation is provided by the system but no need with Angle.

Only 2 files need modification and it shouldn't affect current behaivor:
include/SDL_egl.h and src/video/SDL_egl.c, as in here

https://github.com/native-toolkit/sdl/pull/10/files

The flag name could be SDL_VIDEO_STATIC_ANGLE (instead of NATIVE_TOOLKIT_STATIC_ANGLE) as discussed here https://github.com/native-toolkit/sdl/pull/10

We have tested this with both Windows and UWP, using NME engine (https://github.com/haxenme/nme). 

Releated issue: https://bugzilla.libsdl.org/show_bug.cgi?id=1820

I kindly request you to add it manually, but I could try to prepare a patch file if needed.

Thank you very much
Carlos Madrazo
Comment 1 Carlos 2017-08-22 22:55:10 UTC
Created attachment 2876 [details]
Unix style patches to implement static angle flags

Here are the diffs of the flags that we would like to include, based on the latest mercurial release. This doesn't change the current behaivor when not activated. I have tested compiling with this. Please let me know if it is enough to merge it. Thanks!
Comment 2 Carlos 2017-08-22 23:22:09 UTC
Created attachment 2877 [details]
git patch for static angle flag, if its more useful

Here is the GIT patch, if its more useful to you.  Thanks!
Comment 3 Sam Lantinga 2017-08-28 02:06:37 UTC
This is added, thanks!
https://hg.libsdl.org/SDL/rev/2d3d35b2c95a