| Summary: | CMake build fails on Windows due to: fatal error RC1203: invalid language ID or language name specified | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Daniel <dschreij> |
| Component: | main | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | blocker | ||
| Priority: | P2 | CC: | dschreij, tschwinger |
| Version: | 2.0.5 | ||
| Hardware: | x86_64 | ||
| OS: | Windows (All) | ||
| URL: | https://ci.appveyor.com/project/conda-forge/sdl2-feedstock/build/1.0.12 | ||
| Attachments: |
Fixes this issue
HG changeset patch |
||
|
Description
Daniel
2017-03-21 13:12:03 UTC
This is caused by `add_definitions(/GS-)` in `CMakeLists.txt`. The "definitions" specified with that command are (global for once and) really just for defines, as they affect other tools that may be interested in them, as the resource compiler. As a consequence, `rc.exe` chokes on an option that's intended for `cl.exe` *only*. Created attachment 2734 [details]
Fixes this issue
Attached patch adds the troublesome compiler option as a directory property, which very similar to what `add_definitions` does, except without affecting tools other than the compiler.
Created attachment 2735 [details]
HG changeset patch
Replacing bare diff with a changeset patch.
This should be fixed by this commit: https://hg.libsdl.org/SDL/rev/c92070a96da5 |