We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3589

Summary: X11 driver enables keyrepeat systemwide
Product: SDL Reporter: Andrey Alexeyev <akari>
Component: videoAssignee: Ryan C. Gordon <icculus>
Status: ASSIGNED --- QA Contact: Sam Lantinga <slouken>
Severity: trivial    
Priority: P2 CC: icculus, sezeroz, sylvain.bertrand
Version: HG 2.1   
Hardware: x86_64   
OS: Linux   

Description Andrey Alexeyev 2017-02-17 05:56:03 UTC
Subject. To reproduce: xset r off, make sure key repeat is indeed off, launch any SDL2 applicaion, key repeat is now enabled again. Probably shouldn't mess with the system's settings like this.

Removing the X11_XAutoRepeatOn call from X11_InitKeyboard in video/x11/SDL_x11keyboard.c should fix it, I think.
Comment 1 Ryan C. Gordon 2018-08-07 18:17:15 UTC
I'm inclined to say we shouldn't force autorepeat on. I don't _think_ having it off will break anything (users will get a single, longer-held KEYDOWN event followed by a single KEYUP if they hold down a key, and SDL_TEXTINPUT won't repeat chars, of course), but this should only act differently if the user went out of their way to force it off anyhow, right?

This change happened here originally: https://hg.libsdl.org/SDL/rev/a7cbc25071b6

Sam: any opinions on this?

--ryan.
Comment 2 sylvain.bertrand 2020-04-09 22:05:39 UTC
ping !

This is annoying, indeed.