| Summary: | Misplaced comment #if/#endif closure comment | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Coriiander <coriiander> |
| Component: | audio | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | trivial | ||
| Priority: | P2 | ||
| Version: | 2.0.5 | ||
| Hardware: | All | ||
| OS: | Windows (All) | ||
Fixed, thanks! https://hg.libsdl.org/SDL/rev/a4bf6eab5aef |
This notice is about the following file: "src/audio/xaudio2/SDL_xaudio2.c" This notice is about a misplaced comment. Often times when we use an #if #endif sequence, the #endif is followed by a comment to indicate what #if statement it belonged to. The SDL_xaudio2.c file contains a misplaced comment, as follows (I stripped the other comments): #ifdef __GNUC__ # define SDL_XAUDIO2_HAS_SDK 1 #elif defined(__WINRT__) # define SDL_XAUDIO2_HAS_SDK #include "SDL_xaudio2.h" #else #if 0 #include <dxsdkver.h> #if (!defined(_DXSDK_BUILD_MAJOR) || (_DXSDK_BUILD_MAJOR < 1284)) # pragma message("Your DirectX SDK is too old. Disabling XAudio2 support.") #else # define SDL_XAUDIO2_HAS_SDK 1 #endif #endif #endif /* 0 */ That final /* 0 */ should be moved one line up. Like this (I tabbed it out for you to make it more clear): #ifdef __GNUC__ #define SDL_XAUDIO2_HAS_SDK 1 #elif defined(__WINRT__) #define SDL_XAUDIO2_HAS_SDK #include "SDL_xaudio2.h" #else #if 0 #include <dxsdkver.h> #if (!defined(_DXSDK_BUILD_MAJOR) || (_DXSDK_BUILD_MAJOR < 1284)) #pragma message("Your DirectX SDK is too old. Disabling XAudio2 support.") #else #define SDL_XAUDIO2_HAS_SDK 1 #endif #endif /* 0, comment moved up from the line below this line */ #endif /* moved the 0 one line up */