We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3364

Summary: Couldn't set hardware audio parameters: Success
Product: SDL Reporter: romain145
Component: audioAssignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: minor    
Priority: P2 CC: philipp.wiesemann
Version: 2.0.4   
Hardware: ARM   
OS: Linux   
Attachments: Diff

Description romain145 2016-06-18 14:33:09 UTC 
Created attachment 2499 [details]
Diff

Just found a small omission where the status sent back after error "Couldn't set hardware audio parameters" is rather optimistic: "Success".

The reason is the missing return status value after the call to ALSA_set_period_size.

Before:
A failure in the init returns: "Couldn't set hardware audio parameters: Success"

After:
A failure in the init returns: "Couldn't set hardware audio parameters: Operation not permitted"

Please see attached diff file.
Thanks
Comment 1 Philipp Wiesemann 2016-07-19 19:18:58 UTC 
This patch is now https://hg.libsdl.org/SDL/rev/30ca8e64db6a, thanks!