| Summary: | SDL_windows_main.c defines both console application entry points | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Simon Hug <chli.hug> |
| Component: | main | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED INVALID | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | CC: | philipp.wiesemann |
| Version: | HG 2.0 | ||
| Hardware: | All | ||
| OS: | Windows (All) | ||
| Attachments: | Only define wmain if UNICODE is set. | ||
Fixed, thanks! https://hg.libsdl.org/SDL/rev/92dc590a7116 With that change only the wmain() entry point is defined, and applications that link with main() no longer build. Simon, I can't reproduce the linker issue you're seeing here. I am however able to reproduce not being able to build with your change by creating a new console application in Visual Studio and linking it to SDL. Can you investigate? Oops, my testing was incomplete. I probably linked with the coff object file of SDL_windows_main.c directly instead of packaging it first into a library file. I really thought I tested both. It looks like the MSVC linker ignores the wmain symbol in the lib file when searching for possible entry points. It works if the symbol is in an obj file, but here it just falls back to main. I didn't find a way to get the linker to select it without forcing the entry point manually. How annoying. If unicode arguments are necessary, console_ansi_main could always go the GetCommandLine route like WinMain. That sounds like a good approach. Want to test and submit a patch for that? I have opened a new bug 3452 for that since the issue is a bit different. I guess you can mark this bug as invalid or wontfix. Closing, thanks! |
Created attachment 2443 [details] Only define wmain if UNICODE is set. The SDLmain file src/main/windows/SDL_windows_main.c defines both entry points for console applications, main and wmain. This seems to confuse MSVC. It outputs a LNK4067 warning and then chooses main, which is a shame because only wmain has the unicode handling. Using SDLmain.lib provided on libsdl.org, the linker also goes for main. I'm proposing to not define the main entry point at all. wmain should be supported well enough with MSVC.