| Summary: | Minor improvements to the configure script | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Rafał Mużyło <galtgendo> |
| Component: | build | Assignee: | Sam Lantinga <slouken> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | CC: | icculus |
| Version: | HG 2.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Attachments: | the patch for described problems | ||
I'm pulling in the small CMake fix for now, and will revisit the configure script changes after 2.0.4 has shipped; I'll leave this bug open and assigned to me until then. The CMake fix is now https://hg.libsdl.org/SDL/rev/a80ea42a4adc, thanks! --ryan. Just changing the summary text so I can find this easier, later. --ryan. This is in, thanks! https://hg.libsdl.org/SDL/rev/283194179512 |
Created attachment 2341 [details] the patch for described problems Due to testing for a problem with a different app (that wasn't caused by SDL after all), I've took at master of libsdl2 (which was at the time at a20484c998da). The patch attached addresses a few minor build issues I've noticed: - the define changes in configure.in are mostly cosmetic, due to non-compliant way AC_CONFIG_HEADER is used, still technically more correct - the obvious typo in sdl2-config.cmake.in - the remaining changes are simply cause "if we're already using libtool, why aren't we using it ?"; they've been inspired by the fact, that at that mark, neither libSDL2_test.a nor libSDL2main.a were being built correctly (not sure if it's fully broken or just because I've tested the out-of-tree build)