| Summary: | CMAKE: STDC_HEADERS is not defined except for msvc [patch] | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Martin Gerhardy <martin.gerhardy> |
| Component: | build | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | CC: | icculus |
| Version: | HG 2.1 | Keywords: | target-2.0.4 |
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | the patch for the cmake file | ||
This is defined for non-MSVC targets in the else() block:
check_include_files("dlfcn.h;stdint.h;stddef.h;inttypes.h;stdlib.h;strings.h;string.h;float.h" STDC_HEADERS)
What platform was this failing on? I could see this failing for, say, MingW, which I presume doesn't offer dlfcn.h.
--ryan.
(In reply to Ryan C. Gordon from comment #1) > What platform was this failing on? I could see this failing for, say, MingW, > which I presume doesn't offer dlfcn.h. Just discovered from Bug #3194 that this was probably an Android problem, right? We might just need to special-case that list of headers. I don't think we want to turn on STDC_HEADERS universally. --ryan. yes. was an android issue (In reply to Martin Gerhardy from comment #3) > yes. was an android issue Is it float.h that's missing? --ryan. Weird, but i'm not able to reproduce this anymore. I've tried mingw64_32, emscripten and android ndk. Unfortunately I didn't document which version and which platform it was - so I retested all of them. But i've updated emscripten and the ndk in the meanwhile. So I would say, just close this one and if I ever encounter it again, I will document the stuff properly. Marking fixed, then...reopen if it pops up again! --ryan. |
Created attachment 2330 [details] the patch for the cmake file This leads to all kind of weird issues - but on most platforms to compile errors in SDL_stdinc.h because wchar_t is defined in stddef.h