We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3108

Summary: JPEG Assembly using Android API 21
Product: SDL_image Reporter: Isaac Burns <isaacburns>
Component: miscAssignee: Sam Lantinga <slouken>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2 CC: olli.kallioinen
Version: 2.0.0   
Hardware: ARM   
OS: Android (All)   
Attachments: patch
patch

Description Isaac Burns 2015-08-28 15:47:58 UTC 
Starting with API 21 (android-21), __ARCH_ARM__ < 6 is no longer defined in platforms/android-21/arch-arm/usr/include/machine/cpu-features.h.

Compiling the JPEG library for armeabi errors with: "error Unknown or unsupported ARM architecture".

There may be a better way to patch this in the SDL_image/Android.mk file.

    ifneq (,$(filter $(TARGET_ARCH_ABI),armeabi-v7a arm64-v8a))
        LOCAL_SRC_FILES += $(JPG_LIBRARY_PATH)/jidctfst.S
    else
        LOCAL_SRC_FILES += $(JPG_LIBRARY_PATH)/jidctfst.c
    endif

Somewhat related to Bug #2501.
Comment 1 Isaac Burns 2015-08-28 15:54:08 UTC 
Created attachment 2255 [details]
patch
Comment 2 Isaac Burns 2015-08-28 16:03:06 UTC 
Created attachment 2256 [details]
patch
Comment 3 Isaac Burns 2015-08-28 16:04:17 UTC 
The patch should actually look more like this.

    ifeq ($(TARGET_ARCH_ABI),armeabi-v7a)
        LOCAL_SRC_FILES += $(JPG_LIBRARY_PATH)/jidctfst.S
    else
        LOCAL_SRC_FILES += $(JPG_LIBRARY_PATH)/jidctfst.c
    endif
Comment 4 Sam Lantinga 2017-08-12 19:28:07 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL_image/rev/8402819e7bb2
Comment 5 Sylvain 2017-09-11 18:52:40 UTC 
*** Bug 3694 has been marked as a duplicate of this bug. ***