| Summary: | Statically link sdl2 with /MT for msvc [PATCH] | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Martin Gerhardy <martin.gerhardy> |
| Component: | build | Assignee: | Sam Lantinga <slouken> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | CC: | icculus, mike.linford.reg |
| Version: | HG 2.1 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Attachments: | _MT guard | ||
|
Description
Martin Gerhardy
2015-08-12 15:11:28 UTC
Created attachment 2238 [details]
_MT guard
Fixed, thanks! https://hg.libsdl.org/SDL/rev/4de94185790e This commit broke the Visual Studio build on buildbot, which apparently defines _MT but doesn't include that symbol. What msvc version is running there? I tested it with vs2015 (In reply to Martin Gerhardy from comment #5) > What msvc version is running there? I tested it with vs2015 The buildbot does builds with VS2008 and VS2010 at the moment. This was the VS2008 error messages for this case: https://buildbot.libsdl.org/builders/sdl-visualstudio/builds/2620/steps/compile/logs/errors I don't personally know how to best resolve this (among other options: is it time to drop VS2008?). --ryan. I'm also having trouble statically linking SDL2 on Visual Studio 2015 with /MT. My symptom is that memcpy is being defined twice. I was able to fix it in on my machine by changing line 282 of SDL_stdlib.c to: #if (_MSC_VER >= 1400) && defined(_WIN64) && !defined(_DEBUG) && !(_MSC_VER >= 1900 && defined(_MT)) Patch added, thanks! https://hg.libsdl.org/SDL/rev/d8a72d273dd2 You're welcome. Looks like 2.0.5 is coming up. Think this'll make it in? Yes, it's already in. :) This is resolved. |