We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3082

Summary: invalid function pointer declarations for libpng and SDL2_image
Product: SDL_image Reporter: Martin Gerhardy <martin.gerhardy>
Component: miscAssignee: Sam Lantinga <slouken>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2    
Version: 2.0.0   
Hardware: x86_64   
OS: Linux   
Attachments: fixed some of the function pointers
some more changes.

Description Martin Gerhardy 2015-07-31 10:35:14 UTC 
libpng-1.6.2 (bundles with SDL_image) leads to compiler warnings/errors with msvc:

(ClCompile target) -> 
  IMG_png.c(276): warning C4028: formal parameter 2 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(277): warning C4028: formal parameter 2 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(279): warning C4028: formal parameter 1 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(280): warning C4028: formal parameter 1 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(280): warning C4028: formal parameter 2 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(281): warning C4028: formal parameter 1 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(281): warning C4028: formal parameter 2 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(282): warning C4028: formal parameter 1 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(283): warning C4028: formal parameter 1 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(284): warning C4028: formal parameter 1 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(285): warning C4028: formal parameter 1 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(286): warning C4028: formal parameter 1 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
  IMG_png.c(289): warning C4028: formal parameter 1 different from declaration [C:\projects\caveexpress\src\libs\SDL2_image\SDL2_image.vcxproj]
Comment 1 Martin Gerhardy 2015-07-31 10:37:20 UTC 
Created attachment 2231 [details]
fixed some of the function pointers

this patch is not 100% verified because I don't have msvc available.

But see the output in https://ci.appveyor.com/project/mgerhardy/caveexpress/build/1.0.83
Comment 2 Martin Gerhardy 2015-07-31 10:42:19 UTC 
Created attachment 2232 [details]
some more changes.
Comment 3 Sam Lantinga 2017-10-22 08:42:24 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL_image/rev/ace61a625208