We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3001

Summary: CMake build broken on Windows
Product: SDL Reporter: Joe Thompson <mini_joe>
Component: buildAssignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2 CC: icculus
Version: HG 2.1Keywords: target-2.0.4
Hardware: x86_64   
OS: Windows 7   

Description Joe Thompson 2015-06-04 17:02:21 UTC
The CMake generated solution fails to build (VS2010) since:
changeset 9658	9753468b5c0e
Move tests from SDL_config higher up in Windows joystick/haptic code.

DWORD is not defined.

#if SDL_HAPTIC_XINPUT was moved 
and now 
#include "../../joystick/windows/SDL_windowsjoystick_c.h" is not included which pulls in windef.h
Comment 1 Ryan C. Gordon 2015-06-07 22:30:21 UTC
This is (maybe) fixed by https://hg.libsdl.org/SDL/rev/e501460cb4c4, can you sync up to the latest in revision control and see if it works for you now?

Thanks,
--ryan.
Comment 2 Joe Thompson 2015-06-07 23:19:43 UTC
(In reply to Ryan C. Gordon from comment #1)
> This is (maybe) fixed by https://hg.libsdl.org/SDL/rev/e501460cb4c4, can you
> sync up to the latest in revision control and see if it works for you now?
> 
> Thanks,
> --ryan.

Thanks Ryan.
Builds fine now.
FYI: Don't know if it is intended but SDL_SHARED is "OFF" by default in the CMake configuration.
Thanks,
Joe
Comment 3 Ryan C. Gordon 2015-06-08 00:16:10 UTC
(In reply to Joe Thompson from comment #2)
> Builds fine now.

Yay!

> FYI: Don't know if it is intended but SDL_SHARED is "OFF" by default in the
> CMake configuration.

Whoops, not intended. Fixed here, now: https://hg.libsdl.org/SDL/rev/45a632fd9d83

Thanks again,
--ryan.