We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2881

Summary: Fix extraneous parenthesis warning from clang
Product: SDL Reporter: Simon Deschenes <moi>
Component: hapticAssignee: Edgar Simo <bobbens>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: trivial    
Priority: P5 CC: icculus
Version: HG 2.0Keywords: triage-2.0.4
Hardware: x86_64   
OS: Linux   
Attachments: The patch

Description Simon Deschenes 2015-02-15 23:14:33 UTC
My build system considers warnings as errors, and this was a little warning about extraneous parenthesis I fixed.

In src/haptic/linux/SDL_syshaptic.c
Comment 1 Simon Deschenes 2015-02-15 23:16:57 UTC
Created attachment 2034 [details]
The patch
Comment 2 Simon Deschenes 2015-02-15 23:21:59 UTC
in fact :
SDL_free(item->fname);

is also useless as item->fname is NULL
Comment 3 Ryan C. Gordon 2015-02-19 05:22:17 UTC
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!
Comment 4 Ryan C. Gordon 2015-02-19 18:11:55 UTC
Fixed in https://hg.libsdl.org/SDL/rev/c671d8ca48a1

Thanks!

--ryan.