| Summary: | [patch] Fix android build compiling in wrong filesystem implementation | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Jonas Kulla <ancurio_bugzilla> |
| Component: | build | Assignee: | Gabriel Jacobo <gabomdq> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | CC: | gabomdq, philipp.wiesemann |
| Version: | HG 2.1 | ||
| Hardware: | All | ||
| OS: | Android (All) | ||
| Attachments: |
patch
patch |
||
Created attachment 1954 [details]
patch
Forgot that you guys keep the generated configure script in revision too.
Thank you for the patch. It was applied here: https://hg.libsdl.org/SDL/rev/541f12d1edcd I missed that it broke the configure script for FreeBSD (neither Android nor Linux but needs a filesystem implementation). This was fixed here: https://hg.libsdl.org/SDL/rev/3ad27ca380f3 Ah, my bad, I should have seen that one coming. Thanks for applying and fixing it! |
Created attachment 1953 [details] patch The configure script didn't differentiate between Linux and Android, unconditionally compiling in the unix implementation of SDL_sysfilesystem.c. 'm probably one of the very few people building SDL for android using classic configure + standalone toolchain, so this has gone undetected all along.