| Summary: | Regression: Official wired Xbox 360 controller not detected | ||
|---|---|---|---|
| Product: | SDL | Reporter: | mushman5 |
| Component: | joystick | Assignee: | Sam Lantinga <slouken> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | CC: | amaranth72, wasteland |
| Version: | 2.0.3 | ||
| Hardware: | All | ||
| OS: | Windows (All) | ||
|
Description
mushman5
2014-11-13 12:48:06 UTC
Are you able to test using the latest Mercurial version of SDL (the upcoming 2.0.4)? Just to make sure the issue is still there in the most current code. I'd be happy to test the latest version. However, I am very inexperienced with source code and building projects. I downloaded a ZIP of the project from http://hg.libsdl.org/SDL (revision f6355bfca853) and attempted to compile it with Visual C++ 2010 Express, but the build failed. I tried to look for any exisitng builds of 2.0.4 in the repository but couldn't find one. If you could help me with getting the latest version, I would apprecaite it. Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though! (sorry if you get a lot of copies of this email, I'm marking several bugs at once) Marking bugs for the (mostly) final 2.0.4 TODO list. This means we're hoping to resolve this bug before 2.0.4 ships if possible. In a perfect world, the open bug count with the target-2.0.4 keyword is zero when we ship. (Note that closing a bug report as WONTFIX, INVALID or WORKSFORME might still happen.) --ryan. 360 controllers work for me as of the latest 2.0.4 Mercurial code; should I close this as 'worksforme'? You can download a pre-built release candidate of SDL 2.0.4 here: https://www.libsdl.org/tmp/download-2.0.php This sounds like an issue I ran into and fixed as part of my fix to https://bugzilla.libsdl.org/show_bug.cgi?id=3299 Just the first part of the diff is a trivial fix for this issue for me. At least on my computer, my official Microsoft Xbox wired controllers show up as "Controller (XBOX 360 For Windows)", which is a different case than the code is looking for. diff -r f0645cd8fd39 -r 7161a0cf5b92 src/joystick/SDL_gamecontroller.c --- a/src/joystick/SDL_gamecontroller.c Sun Mar 20 15:35:34 2016 -0300 +++ b/src/joystick/SDL_gamecontroller.c Mon Mar 28 14:17:55 2016 -0700 @@ -660,7 +660,7 @@ if (!mapping) { const char *name = SDL_JoystickNameForIndex(device_index); if (name) { - if (SDL_strstr(name, "Xbox") || SDL_strstr(name, "X-Box")) { + if (SDL_strstr(name, "Xbox") || SDL_strstr(name, "X-Box") || SDL_strstr(name, "XBOX")) { mapping = s_pXInputMapping; } } Jimb's patch is in the latest snapshot: http://www.libsdl.org/tmp/SDL-2.0.zip Please reopen this bug if this doesn't fix the problem for you. Thanks! |