| Summary: | SDL_ShowMessageBox causes modifier keys to stick (patch included) | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Sean McKean <smckean83> |
| Component: | video | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | minor | ||
| Priority: | P2 | CC: | icculus |
| Version: | HG 2.0 | Keywords: | target-2.0.4, triage-2.0.4 |
| Hardware: | x86 | ||
| OS: | Linux | ||
| Attachments: |
patch to clear keyboard state before showing message box
revised patch |
||
Created attachment 1926 [details]
revised patch
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though! (sorry if you get a lot of copies of this email, I'm marking several bugs at once) Marking bugs for the (mostly) final 2.0.4 TODO list. This means we're hoping to resolve this bug before 2.0.4 ships if possible. In a perfect world, the open bug count with the target-2.0.4 keyword is zero when we ship. (Note that closing a bug report as WONTFIX, INVALID or WORKSFORME might still happen.) --ryan. This patch is now https://hg.libsdl.org/SDL/rev/cd237569d0f6, thanks! --ryan. |
Created attachment 1925 [details] patch to clear keyboard state before showing message box When calling SDL_ShowMessageBox with a keyboard modifier held (i.e. showing the box when holding and testing for Shift-Z), the message box receives events normally, but if the modifier key is released with the box still opened, the mod state remains pressed even after the box is dismissed. The proposed patch file simply calls SDL_ResetKeyboard() to clear all held state before showing the dialog. Tested with Ubuntu / Gnome (X11).