We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2653

Summary: Android: Report hardware on startup
Product: SDL Reporter: rettichschnidi <bugzillas>
Component: *don't know*Assignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2 CC: bugzillas
Version: HG 2.0Keywords: target-2.0.4, triage-2.0.4
Hardware: All   
OS: Android (All)   
Attachments: Most simple patch I can think of.
Updated for revision 9372:a9bf04588f17
Remove superfluous whitespace characters

Description rettichschnidi 2014-07-18 09:43:36 UTC
Created attachment 1772 [details]
Most simple patch I can think of.

I have a game for which some users report the red-screen bug[1]. Unfortunately, the user may have an affected "Galaxy Note 10.1 (p4notelte)" device, while my testing device (one from testobject.com) is an unaffected "Galaxy Note 10.1 (p4noterf)". Always including this information in the logcat output allows to identify the currently used device and model. I think this is a pretty common use-case and it would be useful to let SDL report the Android hardware model and device on each startup.

1: https://bugzilla.libsdl.org/show_bug.cgi?id=2291
Comment 1 Ryan C. Gordon 2015-02-19 05:22:21 UTC
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!
Comment 2 rettichschnidi 2015-02-26 22:26:49 UTC
Created attachment 2052 [details]
Updated for revision 9372:a9bf04588f17
Comment 3 Ryan C. Gordon 2015-04-07 04:57:58 UTC
(sorry if you get a lot of copies of this email, I'm marking several bugs at once)

Marking bugs for the (mostly) final 2.0.4 TODO list. This means we're hoping to resolve this bug before 2.0.4 ships if possible. In a perfect world, the open bug count with the target-2.0.4 keyword is zero when we ship.

(Note that closing a bug report as WONTFIX, INVALID or WORKSFORME might still happen.)

--ryan.
Comment 4 Ryan C. Gordon 2015-04-08 05:37:52 UTC
This patch is now https://hg.libsdl.org/SDL/rev/4de1f53b6b6b, thanks!

--ryan.
Comment 5 rettichschnidi 2015-04-08 10:23:28 UTC
Created attachment 2113 [details]
Remove superfluous whitespace characters
Comment 6 rettichschnidi 2015-04-08 10:24:21 UTC
Thanks!

Unfortunately, I accidentally added some unwanted whitespace characters at the end of the first added code line.

This attached patch removes them plus all the other superfluous whitespace characters in the Android source file.
Comment 7 Ryan C. Gordon 2015-04-26 00:44:14 UTC
(In reply to rettichschnidi from comment #6)
> This attached patch removes them plus all the other superfluous whitespace
> characters in the Android source file.

This patch is now https://hg.libsdl.org/SDL/rev/cc6cba65bf36, thanks!

--ryan.