| Summary: | SDL fails to link on non-Windows systems since the recent changes to its Windows XInput code | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Alex Szpakowski <amaranth72> |
| Component: | joystick | Assignee: | Sam Lantinga <slouken> |
| Status: | VERIFIED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | critical | ||
| Priority: | P2 | CC: | aschiffler, binarycrusader, mathstuf |
| Version: | HG 2.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | Adds SDL_FALSE impl for all other platforms | ||
|
Description
Alex Szpakowski
2014-07-04 23:18:07 UTC
Created attachment 1737 [details]
Adds SDL_FALSE impl for all other platforms
Here's a patch which implements all non-Windows platforms with an SDL_FALSE function. Tested with an Android build.
Occurs also on Windows cygwin builds. $ ../configure --disable-haptic --disable-joystick ... SDL2 Configure Summary: Building Shared Libraries Building Static Libraries Enabled modules : atomic audio video render events power filesystem threads timers file loadso cpuinfo assembly Assembly Math : mmx 3dnow sse Audio drivers : disk dummy directx Video drivers : dummy opengl directx Input drivers : Using libudev : NO Using dbus : NO Using ibus : NO $ make #(cd /cygdrive/i/Sources/SDL && sh autogen.sh && sh configure) /bin/sh ../build-scripts/updaterev.sh ... build/.libs/SDL_gamecontroller.o: In function `SDL_PrivateGetControllerMapping': /cygdrive/i/Sources/SDL/src/joystick/SDL_gamecontroller.c:261: undefined reference to `SDL_SYS_IsXInputGamepad_DeviceIndex' /cygdrive/i/Sources/SDL/src/joystick/SDL_gamecontroller.c:261: undefined reference to `SDL_SYS_IsXInputGamepad_DeviceIndex' /cygdrive/i/Sources/SDL/src/joystick/SDL_gamecontroller.c:261: undefined reference to `SDL_SYS_IsXInputGamepad_DeviceIndex' /cygdrive/i/Sources/SDL/src/joystick/SDL_gamecontroller.c:261: undefined reference to `SDL_SYS_IsXInputGamepad_DeviceIndex' /cygdrive/i/Sources/SDL/src/joystick/SDL_gamecontroller.c:261: undefined reference to `SDL_SYS_IsXInputGamepad_DeviceIndex' build/.libs/SDL_gamecontroller.o:/cygdrive/i/Sources/SDL/src/joystick/SDL_gamecontroller.c:261: more undefined references to `SDL_SYS_IsXInputGamepad_DeviceIndex' follow collect2: error: ld returned 1 exit status Makefile:141: recipe for target 'build/libSDL2.la' failed make: *** [build/libSDL2.la] Error 1 This is fixed, thanks! https://hg.libsdl.org/SDL/rev/1a5d959d7b32 Win7/cygwin builds fine now. |