| Summary: | Message boxes under X11 are sluggish | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Melker Narikka <meklu> |
| Component: | video | Assignee: | (disabled) Jørgen Tjernø <jorgen> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | CC: | icculus, jorgen |
| Version: | HG 2.1 | Keywords: | target-2.0.4, triage-2.0.4 |
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Attachments: |
patch to reduce unnecessary rendering
patch that adds Xdbe support patch that adds Xdbe support - v2 patch that adds Xdbe support - v3 |
||
Created attachment 1532 [details]
patch that adds Xdbe support
The attached patch adds Xdbe support and makes message boxes flicker-free.
It is an extension of the initial patch, i.e. it contains its changes as well.
It should contain the necessary build system changes too.
Created attachment 1533 [details]
patch that adds Xdbe support - v2
This patch adds a more proper runtime check for Xdbe, a call to XdbeQueryExtension. In addition, it also includes the changes made to ./configure by ./autogen.sh.
Created attachment 1539 [details]
patch that adds Xdbe support - v3
The only difference here compared to v2 should be the incorporation of the pretty new autoconf logging introduced in 5226058345bf. This is a one-line change in configure.in.
http://hg.libsdl.org/SDL/rev/06922987b6ff Will add Xdbe support after 2.0.2 ships. Comment on attachment 1539 [details] patch that adds Xdbe support - v3 Checking if the mouseover index changed is now https://hg.libsdl.org/SDL/rev/06922987b6ff ... We'll leave this open until the rest of the patch is dealt with, though! --ryan. (In reply to Jørgen Tjernø from comment #4) > http://hg.libsdl.org/SDL/rev/06922987b6ff > > Will add Xdbe support after 2.0.2 ships. Oh, yeah, what he said. :) --ryan. Any word on this? The patch still seems to apply. :) Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though! (sorry if you get a lot of copies of this email, I'm marking several bugs at once) Marking bugs for the (mostly) final 2.0.4 TODO list. This means we're hoping to resolve this bug before 2.0.4 ships if possible. In a perfect world, the open bug count with the target-2.0.4 keyword is zero when we ship. (Note that closing a bug report as WONTFIX, INVALID or WORKSFORME might still happen.) --ryan. The Xdbe support is now in revision control as https://hg.libsdl.org/SDL/rev/fbc01731d914, thanks! --ryan. |
Created attachment 1519 [details] patch to reduce unnecessary rendering Message boxes do a full re-render whenever the mouse moves. With a long message string, this will result in flickering graphics and poor responsiveness. The attached patch works around this issue by avoiding a re-render unless button focus changes. It would probably be better to add XDamage and/or Xdbe support.