We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2326

Summary: Improve Performance in SDL_x11events.c file.
Product: SDL Reporter: Nitz <nitin.j4>
Component: videoAssignee: Gabriel Jacobo <gabomdq>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2 CC: gabomdq, icculus, nitin.j4
Version: HG 2.0   
Hardware: x86   
OS: Linux   
Attachments: patch for SDL_x11events.c and SDL_x11video.h file

Description Nitz 2013-12-24 06:28:43 UTC 
In SDL_x11events.c file, SDL_x11video.h header include twice
Even Include guards are used to protect any kind of error but
still this should be removed as it is creating confusion.

In SDL_x11events.c file the are two functions declaration :
int SDL_GetNumTouch(void);
void SDL_dbus_screensaver_tickle(_THIS);

SDL_GetNumTouch function definition is not in SDL only declaration happen
So SDL_GetNumTouch declaration should be removed from SDL_x11events.c file.

SDL_dbus_screensaver_tickle function declaration is in SDL_x11events.c file
but it would be better if this declaration get move to SDL_x11video.h file.

Thanks...
Comment 1 Gabriel Jacobo 2014-02-20 20:18:01 UTC 
If you can provide these changes in patch form I'll review and incorporate them.
Comment 2 Nitz 2014-02-21 03:01:41 UTC 
Created attachment 1569 [details]
patch for SDL_x11events.c and SDL_x11video.h file
Comment 3 Gabriel Jacobo 2014-02-21 11:39:15 UTC 
https://hg.libsdl.org/SDL/rev/437c4e5961e0

BTW, what you attached is not a patch :)