We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2142

Summary: missing include of dynamic_fluidsynth.h in mixer.c
Product: SDL_mixer Reporter: manuel.montezelo
Component: miscAssignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: minor    
Priority: P2    
Version: unspecified   
Hardware: x86_64   
OS: Linux   

Description manuel.montezelo 2013-10-09 19:37:37 UTC
Hi,

I think that mixer is not including dynamic_fluidsynth.h in this block:

#include "SDL_mixer.h"
#include "load_aiff.h"
#include "load_voc.h"
#include "load_ogg.h"
#include "load_flac.h"
#include "dynamic_flac.h"
#include "dynamic_modplug.h"
#include "dynamic_mod.h"
#include "dynamic_mp3.h"
#include "dynamic_ogg.h"

So the compiler then generates these warnings (as spotted in [1]):

[1] http://qa.debian.org/bls/packages/l/libsdl2-mixer.html

W implicit-declaration mixer.c:154
W implicit-declaration mixer.c:215

I don't think that there's a big problem unless, but anyway, it probably should be fixed to avoid possible problems in the future.


Hope that helps.
Comment 1 Sam Lantinga 2013-10-14 03:03:25 UTC
Fixed, thanks!
http://hg.libsdl.org/SDL_mixer/rev/8b25e64c7ac7