| Summary: | Mac: dead code for supporting OS 10.4 | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Alex Szpakowski <amaranth72> |
| Component: | *don't know* | Assignee: | Alex Szpakowski <amaranth72> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | trivial | ||
| Priority: | P2 | ||
| Version: | HG 2.0 | ||
| Hardware: | x86 | ||
| OS: | Mac OS X (All) | ||
| Attachments: |
Patch to remove pre-10.5 Cocoa code
Removing obsolete codepaths |
||
|
Description
Alex Szpakowski
2013-07-13 02:51:39 UTC
Sounds good. Would you like to provide a tested patch? Created attachment 1231 [details] Patch to remove pre-10.5 Cocoa code I've attached a patch with my modifications so the source. I did some testing on Mac OS 10.8 and 10.5 but it was not extremely thorough. I didn't remove this code: http://hg.libsdl.org/SDL/file/964e8876ad3b/src/video/cocoa/SDL_cocoawindow.m#l975 because I don't know whether it applies to 10.5+ as well or not. This should mostly be done. Can you verify the current snapshot? http://www.libsdl.org/tmp/SDL-2.0.zip Thanks! There's still a code path which is only taken for OS 10.2 and below, and some other misc. dead stuff. I'll make a patch to remove it tomorrow. There is one thing I am not sure about. This comment is ambiguous as to whether the line is needed in 10.5+: http://hg.libsdl.org/SDL/file/4bb403bb0c06/src/video/cocoa/SDL_cocoawindow.m#l1030 So I won't remove it in my patch. Created attachment 1390 [details]
Removing obsolete codepaths
The new patch removes all the truly obsolete code I could find. I tested on OS 10.8 and OS 10.5.
It doesn't remove the setAppleMenu thing like my old patch did. I found out doing so broke the menu a little bit in 10.5.
Looks good, thanks! https://hg.libsdl.org/SDL/rev/f5f51b3c4dd2 |