| Summary: | Various ASM PIC issues... | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Ryan C. Gordon <icculus> |
| Component: | *don't know* | Assignee: | Ryan C. Gordon <icculus> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | CC: | jwrdegoede, vapier |
| Version: | don't know | ||
| Hardware: | x86 | ||
| OS: | Other | ||
| Attachments: |
no-exec-stack
hermes-call-dont-jump hermes-cpuid load-mmx-masks-from-stack SDL_stretch-PIC libsdl-1.2.9-PIC-load-mmx-masks-from-stack.patch |
||
|
Description
Ryan C. Gordon
2006-01-03 12:03:28 UTC
Created attachment 10 [details]
no-exec-stack
Created attachment 11 [details]
hermes-call-dont-jump
Created attachment 12 [details]
hermes-cpuid
Created attachment 13 [details]
load-mmx-masks-from-stack
Please note that some (or all?) of these might have been applied to CVS, and some (or all?) might have been declared broken by Mike later on. Please follow up with Mike before committing! --ryan. Created attachment 14 [details]
SDL_stretch-PIC
Comment on attachment 10 [details]
no-exec-stack
this has been committed
Comment on attachment 12 [details]
hermes-cpuid
this hermes-cpuid patch is still applicable
Comment on attachment 14 [details]
SDL_stretch-PIC
this SDL_stretch change is safe and still applicable
Comment on attachment 13 [details]
load-mmx-masks-from-stack
this load mmx masks is safe and still applicable
Comment on attachment 11 [details]
hermes-call-dont-jump
i would put this on hold as it can be solved with just a few lines of code once ELF visibility is added to nasm, so i wouldnt bother changing it now
hermes-cpuid is in CVS. --ryan. Comment on attachment 12 [details]
hermes-cpuid
(Tagging cpuid patch as obsolete so I know it's done with.)
--ryan.
Comment on attachment 14 [details]
SDL_stretch-PIC
SDL_stretch patch is in CVS now.
--ryan.
Mike,
In the mmx-masks-from-stack patch:
Why was this a problem:
movq mm6, qword [mmx32_rgb888_mask]
But this one in _ConvertMMXpII32_16RGB555 wasn't:
movq mm7,qword [mmx32_rgb555_mul]
(and a few others)
--ryan.
Created attachment 17 [details]
libsdl-1.2.9-PIC-load-mmx-masks-from-stack.patch
hrm, it looks like in my original e-mail i attached two patches named the samething ... the first one was incomplete and is the one you see here
here is the "full" version :)
Comment on attachment 17 [details]
libsdl-1.2.9-PIC-load-mmx-masks-from-stack.patch
MMX patch is in CVS now.
--ryan.
Look at that, we're out of patches! :) I'm resolving this bug now. Thanks, Mike! --ryan. awesome ... i'll file a new bug for the other issue once i can get the nasm guys to wake up Setting Sam as "QA Contact" on all bugs (even resolved ones) so he'll definitely be in the loop to any further discussion here about SDL. --ryan. *** Bug 418 has been marked as a duplicate of this bug. *** |