We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1662

Summary: macros should not use unparenthesized parameters
Product: SDL_net Reporter: Carl Reinke <sandbox+libsdl>
Component: miscAssignee: Sam Lantinga <slouken>
Status: RESOLVED INVALID QA Contact:
Severity: normal    
Priority: P2    
Version: 1.2.8   
Hardware: All   
OS: All   

Description Carl Reinke 2012-12-12 22:59:30 UTC 
See section 3.10.2 of [1] for a detailed explanation of why.

The particular macros that I've experienced violating this are SDL_Write16 and SDL_Write32.  There may be others.

[1] http://linux.web.cern.ch/linux/scientific4/docs/rhel-cpp-en-4/macro-pitfalls.html
Comment 1 Carl Reinke 2012-12-12 23:01:14 UTC 
Sorry, that should be SDLNet_Write16 and SDLNet_Write32.
Comment 2 Sam Lantinga 2012-12-31 16:31:57 UTC 
Is this with the latest version of SDL_net in Mercurial?
http://hg.libsdl.org/SDL_net/

It looks like this has already been cleaned up (but not yet released)
Comment 3 Carl Reinke 2013-01-04 09:57:37 UTC 
Indeed, it does appear to be fixed in Mercurial.