| Summary: | SDL_Touch::FreeTouch uninitialized | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Alexander Hirsch <1zeeky> |
| Component: | events | Assignee: | Sam Lantinga <slouken> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | critical | ||
| Priority: | P2 | CC: | 1zeeky, jorgen |
| Version: | HG 2.0 | Keywords: | target-2.0.0 |
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 1581 | ||
| Attachments: | PARTIAL (!) fix | ||
(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.) Tagging a bunch of bugs as target-2.0.0, Priority 2. This means we're in the final stretch for an official SDL 2.0.0 release! These are the bugs we really want to fix before shipping if humanly possible. That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.0 release, and generally be organized about what we're aiming to ship. Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment. Thanks! --ryan. Should no longer be a problem after Sam's change http://hg.libsdl.org/SDL/rev/7833f01322b3 |
Created attachment 936 [details] PARTIAL (!) fix Several event-implementations do not set SDL_Touch::FreeTouch. Attempts to call it result in crashes (or undefined behavior). In fact, only the Android-implementation nulls the SDL_Touch before operating on it. I do not know Obj-C, so I can't judge (or fix if necessary) the Cocoa and UIKit implementations. The attached (possibly) PARTIAL patch nulls the SDL_Touch-es for Windows and both X11 input implementations before accessing it. The Cocoa and UIKit implementations might still need fixing if Obj-C does not automatically null struct-allocations on the stack. I did not find any other places that (might) need this fixed. I did a "grep SDL_AddTouch src/**/*(.)" (<3 zsh), so I'm pretty sure these are all. Please also note that I've only tested the XInput 2 implementation, but since the changes made for the individual input implementations are trivial I have no reason to believe that the other changed implementations suffer any regressions.