| Summary: | updaterev.sh fails when path contains spaces | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Andreas Schiffler <aschiffler> |
| Component: | build | Assignee: | Andreas Schiffler <aschiffler> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | blocker | ||
| Priority: | P2 | ||
| Version: | HG 2.0 | ||
| Hardware: | x86_64 | ||
| OS: | Windows 7 | ||
| Attachments: | Fixed updaterev.sh | ||
Assigning to myself to apply the fix. Patch applied and verified using this procedure (cd SDL/build && make && make install) ... works (tar cvf SDL.tar && mkdir "Folder with Spaces" && cd "Folder with Spaces" && tar cvf ../SDL.tar && cd SDL/build && make clean && make && make install) ... still works. |
Created attachment 930 [details] Fixed updaterev.sh Building from /cygdrive/c/Users/Andreas Schiffler/Desktop/Sources/SDL/build on Windows using cygwin fails with $ make Warning, configure.in is out of date #(cd .. && sh autogen.sh && sh configure) /bin/sh ../build-scripts/updaterev.sh mv: target `Schiffler/Desktop/Sources/SDL/build/include/SDL_revision.h' is not a directory Makefile:113: recipe for target `update-revision' failed make: *** [update-revision] Error 1 The script build-scripts/updaterev.sh needs to be updated to support paths with spaces in it by wrapping all occurrences of $header into "..". Patch of fix attached.