| Summary: | some small GL context creation enhancements | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Matthias Bentrup <matthias.bentrup> |
| Component: | video | Assignee: | Sam Lantinga <slouken> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | enhancement | ||
| Priority: | P1 | CC: | icculus |
| Version: | HG 2.0 | Keywords: | target-2.0.0 |
| Hardware: | All | ||
| OS: | Linux | ||
| Attachments: | newcontextflags.diff | ||
|
Description
Matthias Bentrup
2012-08-09 12:53:17 UTC
Created attachment 920 [details]
newcontextflags.diff
This patch looks good to me. --ryan. I applied your patch, but it didn't compile on Windows. I think I fixed it, but can you double check that it works properly? http://hg.libsdl.org/SDL/rev/a773384edf20 Thanks! Also, should we just remove the SDL_GL_CONTEXT_PROFILE_ES2 flag? I'm not sure it's worth keeping it around for compatibility in these early days of SDL2. --ryan. Removed!
Looking a little closer, since Buildbot threw a compiler warning for this code:
_this->gl_data->wglShareLists(share_context, hdc);
Should that "hdc" have been "context"?
Also, while I'm looking at this: is sharing display lists _that_ important? Is there WGL (and glX, etc) functionality to share something that's useful in 2012, like buffer objects, textures, or shaders? If not, we should drop this piece of the patch (the rest of the improvements seem okay, though).
--ryan.
Hello Ryan, yes that has to be a HGLDC, so context is correct. wglShareLists is the method to share buffers, textures, shaders if you cannot use wglCreateContextAttribsARB, which has a separate share_context parameter. Matthias (In reply to comment #7) > yes that has to be a HGLDC, so context is correct. Ok, I fixed that in hg changeset 3a098f2d4dea. > wglShareLists is the method to share buffers, textures, shaders if you > cannot use wglCreateContextAttribsARB, which has a separate > share_context parameter. You're right, the MSDN documentation is incorrect: http://www.opengl.org/wiki/Platform_specifics:_Windows#wglShareLists I think we're good to go, then. Sam, should we resolve this bug? --ryan. (Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.) Tagging a bunch of bugs as target-2.0.0, Priority 1. This means we're in the final stretch for an official SDL 2.0.0 release! These are the bugs we really want to fix before shipping if humanly possible. That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.0 release, and generally be organized about what we're aiming to ship. Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment. Thanks! --ryan. (In reply to comment #8) > I think we're good to go, then. Sam, should we resolve this bug? Resolving this bug, because I'm pretty sure we covered everything reported in it. If this was in error, please reopen it. --ryan. |