| Summary: | X11 event driver: Conditional jump on uninitialized value on get_modifier_masks() | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Rodolfo <rodolforg> |
| Component: | video | Assignee: | Sam Lantinga <slouken> |
| Status: | RESOLVED ENDOFLIFE | QA Contact: | Sam Lantinga <slouken> |
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | 1.2.15 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
Hello, and sorry if you're getting several copies of this message by email, since we are closing many bugs at once here. We have decided to mark all SDL 1.2-related bugs as RESOLVED ENDOFLIFE, as we don't intend to work on SDL 1.2 any further, but didn't want to mark a large quantity of bugs as RESOLVED WONTFIX, to clearly show what was left unattended to and make it easily searchable. Our current focus is on SDL 2.0. If you are still having problems with an ENDOFLIFE bug, your absolute best option is to move your program to SDL2, as it will likely fix the problem by default, and give you access to modern platforms and tons of super-cool new features. Failing that, we _will_ accept small patches to fix these issues, and put them in revision control, although we do not intend to do any further official 1.2 releases. Failing that, please feel free to contact me directly by email (icculus@icculus.org) and we'll try to find some way to help you out of your situation. Thank you, --ryan. |
Since first file revision of src/video/x11/SDL_x11events.c available, there is a not initialized value checked in an if statement. Here it is in 1.2.15 revision. 1201 static void get_modifier_masks(Display *display) 1202 { 1203 static unsigned got_masks; 1204 int i, j; 1205 XModifierKeymap *xmods; 1206 unsigned n; 1207 1208 if(got_masks) 1209 return; Line 1203 should be: static unsigned got_masks = 0;